Enable underlining hyperlink on hover even if not focused #8615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-TerminalControl
amanda008868
approved these changes
Dec 19, 2020
ghost
closed this
|
What happened? We aren’t ignoring you, the team is on vacation for the rest of the year. You can leave your pull request open and we will review it when we are back in the office! |
ghost
reopened this
| @@ -1344,8 +1344,10 @@ namespace winrt::Microsoft::Terminal::TerminalControl::implementation | |||
|
|
|||
| const auto ptr = args.Pointer(); | |||
| const auto point = args.GetCurrentPoint(*this); | |||
| const auto cursorPosition = point.Position(); | |||
| const auto terminalPosition = _GetTerminalPosition(cursorPosition); | |||
There was a problem hiding this comment.
nit: with these 2 declarations here, the cursorPosition and terminalPos declarations below (lines 1369 and 1412) can be removed
zadjii-msft
approved these changes
Jan 7, 2021
|
I made the requested changes. This PR is 20 days old and I don't want to make @Hegunumo spend another cycle on it. 😄 |
DHowett
changed the title
PankajBhojwani
approved these changes
Jan 7, 2021
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
ghost
mentioned this pull request
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Jan 28, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8475