Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix right-click paste to clear current selection #8742

Merged
1 commit merged into from Jan 12, 2021
Merged

Fix right-click paste to clear current selection #8742

1 commit merged into from Jan 12, 2021

Conversation

Don-Vito
Copy link
Contributor

@Don-Vito Don-Vito commented Jan 11, 2021 •
edited by DHowett

Closes #8729

@ghost ghost added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Jan 11, 2021
@Don-Vito Don-Vito changed the title Fix right-click paste to unselect current selection Fix right-click paste to clear current selection Jan 11, 2021
zadjii-msft
zadjii-msft approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy-button.png

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 12, 2021
@ghost
Copy link

ghost commented Jan 12, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

DHowett
DHowett approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line, big difference.

@ghost ghost merged commit 20fc57e into microsoft:main Jan 12, 2021
DHowett pushed a commit that referenced this pull request Jan 25, 2021
@Don-Vito @DHowett
Fix right-click paste to clear current selection (#8742)
fd2b3f7 
Closes #8729

(cherry picked from commit 20fc57e)
@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal v1.5.10271.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 28, 2021
Closed
@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal Preview v1.6.10272.0 has been released which incorporates this pull request.:tada:

Handy links:

mpela81 pushed a commit to mpela81/terminal that referenced this pull request Jan 28, 2021
@Don-Vito @mpela81
Fix right-click paste to clear current selection (microsoft#8742)
d74b692 
Closes microsoft#8729
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Right-click paste preserves the selection, but keyboard paste clears it
3 participants
@Don-Vito @DHowett @zadjii-msft