Bind LaunchMode and TabSwitcherMode properly in SUI #8956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Settings UI
PankajBhojwani
approved these changes
Jan 29, 2021
carlos-zamora
added
zPreview-Service-Queued-1.13
ghost
requested review from
zadjii-msft
approved these changes
Feb 1, 2021
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett
removed
the
zPreview-Service-Queued-1.13
DHowett
pushed a commit
that referenced
this pull request
Feb 5, 2021
## Summary of the Pull Request Properly binds `CurrentLaunchMode` and `CurrentTabSwitcherMode` in the Settings UI. The default mode is `OneTime`, resulting in the setting never being set. I performed a regex search of all "SelectedItem" bindings and these were the only two that were not properly bound. ## References #6800 - Settings UI Epic ## Validation Steps Performed Modified tab switcher mode and launch mode via the settings UI. Then saved. Before, the settings would revert back and not get applied. Now they got applied. Closes #8947 (cherry picked from commit 597a332)
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Properly binds
CurrentLaunchModeandCurrentTabSwitcherModein the Settings UI. The default mode isOneTime, resulting in the setting never being set.I performed a regex search of all "SelectedItem" bindings and these were the only two that were not properly bound.
References
#6800 - Settings UI Epic
Validation Steps Performed
Modified tab switcher mode and launch mode via the settings UI. Then saved. Before, the settings would revert back and not get applied. Now they got applied.
Closes #8947