Replace conhost's fmt::format strings with FMT_COMPILEd ones #9581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces by 10% the binary size of OpenConsole x64 Release. Note | OpenConsole.exe ------ | --------------------------- Before | 1156096 After | 1037312 Delta | -118784 %Delta | -10.27%
carlos-zamora
approved these changes
Mar 22, 2021
| @@ -94,6 +94,7 @@ | |||
|
|
|||
| // {fmt}, a C++20-compatible formatting library | |||
| #include <fmt/format.h> | |||
There was a problem hiding this comment.
Wait, if you're "replacing" it, we can't remove this line?
There was a problem hiding this comment.
This is the pre-roll include for all projects in our entire solution ;) and it actually also is the main gateway into fmt.
There is no FMT_COMPILE without fmt::format, and fmt::format comes from fmt/format.h
zadjii-msft
approved these changes
Mar 22, 2021
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
DHowett
added a commit
that referenced
this pull request
Apr 13, 2021
This reduces by 10% the binary size of OpenConsole x64 Release. Note | OpenConsole.exe ------ | --------------------------- Before | 1156096 After | 1037312 Delta | -118784 %Delta | -10.27% (cherry picked from commit d972ea2)
|
🎉 Handy links: |
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces by 10% the binary size of OpenConsole x64 Release.