Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent arrow keys from dismissing tab renamer #9633

Merged
2 commits merged into from
Mar 29, 2021
Merged

Prevent arrow keys from dismissing tab renamer #9633

2 commits merged into from
Mar 29, 2021

Conversation

Don-Vito
Copy link
Contributor

PR Checklist

@Don-Vito
Copy link
Contributor Author

@KalleOlaviNiemitalo - FYI

@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Mar 29, 2021
DHowett
DHowett requested changes Mar 29, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly blocking over the question about whether it breaks other things.

src/cascadia/TerminalApp/TabHeaderControl.cpp
_receivedKeyDown = true;

// GH#9632 - mark navigation buttons as handled.
// This should prevent the tab view to use this key for navigation between tabs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this break ctrl-left (move back word), shift-left (select leftward), etc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this will not break it. The internal behavior remains unchanged (actually, since this even is bubbling up, it cannot physically affect the internal behavior). It just suggests the parent not to handle this event.

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 29, 2021
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 29, 2021
@DHowett
Copy link
Member

DHowett commented Mar 29, 2021

Thanks!

@ghost
Copy link

ghost commented Mar 29, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 704836e into microsoft:main Mar 29, 2021
DHowett pushed a commit that referenced this pull request Apr 13, 2021
@Don-Vito @DHowett
Prevent arrow keys from dismissing tab renamer (#9633)
fadd185 
## PR Checklist
* [x] Closes #9632
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

(cherry picked from commit 704836e)
@ghost
Copy link

ghost commented Apr 14, 2021

🎉Windows Terminal v1.7.1033.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Apr 14, 2021
Closed
@ghost
Copy link

ghost commented Apr 14, 2021

🎉Windows Terminal Preview v1.8.1032.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Don-Vito @DHowett @zadjii-msft