Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add work item linking and comment resolution branch policies #144

Merged
merged 2 commits into from
Aug 13, 2020

Conversation

beandrad
Copy link
Contributor

@beandrad beandrad commented Aug 10, 2020

So that work item linking and comment resolution policies can be enabled/disabled using Terraform.

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Allow to manage work item linking and comment resolution branch policies using Terraform.

Issue Number: closes #114

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@beandrad beandrad changed the title Add work item linking and comment resolution branch policies WIP: Add work item linking and comment resolution branch policies Aug 10, 2020
@ghost ghost added size/XL and removed size/L labels Aug 10, 2020
@beandrad beandrad changed the title WIP: Add work item linking and comment resolution branch policies Add work item linking and comment resolution branch policies Aug 10, 2020
@xuzhang3 xuzhang3 self-assigned this Aug 11, 2020
Copy link
Collaborator

@xuzhang3 xuzhang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @beandrad , Thanks for your contribution. Can you help add some acctests for the new resources item-link and comment-resolution? Branch policy AccTests

azuredevops/internal/service/policy/common.go Show resolved Hide resolved

# azuredevops_branch_policy_comment_resolution

Configure a comment resolution policy for your branch within Azure DevOps.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

within Azure DevOps project might be more clear for users.

Azure DevOps Branch Policies can be imported using the project ID and policy configuration ID:

```sh
terraform import azuredevops_branch_policy_work_item_linking.p aa4a9756-8a86-4588-86d7-b3ee2d88b033/60
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensitive data should be replaced with 00000000-0000-0000-0000-000000000000/00

Azure DevOps Branch Policies can be imported using the project ID and policy configuration ID:

```sh
terraform import azuredevops_branch_policy_comment_resolution.p aa4a9756-8a86-4588-86d7-b3ee2d88b033/60
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensitive data should be replaced with 00000000-0000-0000-0000-000000000000/00

@beandrad beandrad force-pushed the issue-114 branch 2 times, most recently from ad38429 to bfd63a5 Compare August 13, 2020 08:00
So that work item linking policy can be enabled/disabled using Terraform.
So that comment resolution branch policy for AzDO repos can be managed
using Terraform.
@xuzhang3 xuzhang3 merged commit ee0438b into microsoft:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch policies for repository
2 participants