Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project_id to data_project #163

Merged
merged 4 commits into from
Aug 26, 2020
Merged

Conversation

EliiseS
Copy link
Member

@EliiseS EliiseS commented Aug 24, 2020

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number: closes #162

Does this introduce a change to go.mod, go.sum or vendor/?

  • No

Does this introduce a breaking change?

  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@EliiseS
Copy link
Member Author

EliiseS commented Aug 24, 2020

It might be worth removing the project_name field and just having the project_id field accept both. Didn't do that atm because of breaking changes, but it's an easy change

@EliiseS EliiseS requested a review from xuzhang3 August 24, 2020 14:26
@xuzhang3
Copy link
Collaborator

LGTM

@xuzhang3 xuzhang3 merged commit 7effde4 into master Aug 26, 2020
@xuzhang3 xuzhang3 deleted the es/add-project-id-to-data-project branch February 21, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add project_id as alternative attribute for project data source
2 participants