Enable cluster_admin in Kubernetes service connections

[Chathuru]

All Submissions:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• My code follows the code style of this project.
• I ran lint checks locally prior to submission.
• Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Allow to enable and disable cluster_admin in Kubernetes service connections with Azure subscription authentication type.

Issue Number: #216

Does this introduce a change to go.mod, go.sum or vendor/?

• Yes
• No

Does this introduce a breaking change?

• Yes
• No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

[ghost]

All CLA requirements met.

[xuzhang3]

@Chathuru Looks good for your first PR. A few changes requested.
You need add an acceptance test(Terraform Acceptance Test) for the new property in resource_serviceendpoint_kubernetes_test.go. We use acceptance to ensure that the provider is work correct.
An example acceptance test:

var config = `
resource azuredevops_project "project" {
  name = "k8s-test"
  description        = "Test Project Description"
  visibility         = "private"
  version_control    = "Git"
  work_item_template = "Agile"

  features = {
      "testplans" = "disabled"
      "artifacts" = "disabled"
  }
}

resource "azuredevops_serviceendpoint_kubernetes" "serviceendpoint" {
  project_id = azuredevops_project.project.id
  service_endpoint_name = "k8s-test-ado"
  apiserver_url = "https://sample-kubernetes-cluster.hcp.westeurope.azmk8s.io"
  authorization_type = "AzureSubscription"
//  description = "managed by terraform"

  azure_subscription {
    subscription_id = "00000000-0000-0000-0000-000000000000"
    subscription_name = "Test Subscription Name"
    tenant_id = "00000000-0000-0000-0000-000000000000"
    resourcegroup_id = "Test-Resource-Group"
    namespace = "default"
    cluster_name = "TestClusterName"
    cluster_admin = true
  }
}`

[xuzhang3]

1. cluster_admin should be changed to clusterAdmin, this is the property name returned by service.
2. You need handle the error return by strconv.ParseBool(arg1, arg2)

[Chathuru]

1. Use fmt.Errorfto handelstrconv.ParseBool(arg1, arg2)` error. Is this the correct way to handle errors?
2. Don’t we need to handle errors in https://github.com/Chathuru/terraform-provider-azuredevops/blob/master/azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_kubernetes.go#L291 as well?

Still working on the acceptance test

[xuzhang3]

You are correct. The error should be handled when strconv.ParseBool working incorrect. https://github.com/Chathuru/terraform-provider-azuredevops/blob/master/azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_kubernetes.go#L291

[xuzhang3]

LGTM