Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/build definition permissions #254

Merged

Conversation

josh-barker-coles
Copy link
Contributor

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

This PR creates a resource to create/manage permissions on build definitions.

Issue Number: #251

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

@ghost
Copy link

ghost commented Dec 14, 2020

CLA assistant check
All CLA requirements met.

@xuzhang3 xuzhang3 linked an issue Dec 29, 2020 that may be closed by this pull request
@xuzhang3
Copy link
Collaborator

xuzhang3 commented Jan 5, 2021

Hi @josh-barker-coles you need add the document build_definition_permissions.html.markdown to azuredevops.erb

@xuzhang3
Copy link
Collaborator

xuzhang3 commented Jan 5, 2021

LGTM

@xuzhang3 xuzhang3 merged commit 8505ae0 into microsoft:master Jan 5, 2021
@josh-barker-coles josh-barker-coles deleted the feat/build-definition-permissions branch January 5, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Manage Permissions on Build Definitions
2 participants