Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Git repo source_type default value #265

Merged
merged 3 commits into from Jan 11, 2021

Conversation

xuzhang3
Copy link
Collaborator

@xuzhang3 xuzhang3 commented Jan 4, 2021

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number: #246
source_type and source_url is used when init_type is Import, should not set the default value.

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@xuzhang3 xuzhang3 changed the title Remove default source_type, add compatible with v0.0.1 .tfstate files Remove Git repo source_type default value Jan 5, 2021
@xuzhang3 xuzhang3 merged commit 637596b into microsoft:master Jan 11, 2021
@xuzhang3 xuzhang3 deleted the fix/repo_suorce_type branch March 22, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant