Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Service connection description nil panic and document update #60

Merged
merged 15 commits into from
Jul 9, 2020
Merged

Fix Service connection description nil panic and document update #60

merged 15 commits into from
Jul 9, 2020

Conversation

xuzhang3
Copy link
Collaborator

@xuzhang3 xuzhang3 commented Jul 7, 2020

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number: #26

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

xuzhang3 and others added 14 commits June 30, 2020 11:03
@xuzhang3
Create main.yml
1622ef2
@xuzhang3
Delete main.yml
a27e892
@mikaelkrief @xuzhang3
Update Readme
dac5a09 
Remove the Installation Section:
Because the provider is integrated in the registry, there is no need to install it manually
@xuzhang3
This change adds a missing reference to project_features documentation
85c90de
@EliiseS @xuzhang3
Update docs
5e54bf8
@EliiseS @xuzhang3
Format markdown
89cd312
@erikerikson @xuzhang3
Make link text correspond to resource type name
bfc8f73 
Sorry for the nit but was slightly confused by not being able to find `azuredevops_git_repository` in the sidebar.  After clicking on `azuredevops_azure_git_repository` I found what I was looking for but this change should reduce friction for others.  I might suggest changing the linked pages names too but that's stylistic.
@EliiseS @xuzhang3
Update golang extension name
3bc2e17
@EliiseS @xuzhang3
Use correct terraform extension
8c22771
@xuzhang3
Update action CI .yml
72a707e
@xuzhang3
omit accetests
f5369cd
@xuzhang3
add unit test step
16668d3
@xuzhang3
Merge remote-tracking branch 'remotes/upstream/master'
97bc2e0 
# Conflicts:
#	website/docs/r/azure_git_repository.html.markdown
@xuzhang3
Fix pointer nil panic
a8669e2
@ghost ghost added the size/XS label Jul 7, 2020
@xuzhang3 xuzhang3 mentioned this pull request Jul 7, 2020
Closed
@xuzhang3 xuzhang3 requested a review from EliiseS July 7, 2020 07:40
@ghost ghost added the documentation label Jul 7, 2020
@xuzhang3 xuzhang3 changed the title Fix Service connection description nil panic Fix Service connection description nil panic and document update Jul 7, 2020
@xuzhang3 xuzhang3 merged commit e24bb81 into microsoft:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliiseS EliiseS Awaiting requested review from EliiseS

Assignees
No one assigned
Labels
documentation enhancement size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xuzhang3 @mikaelkrief @EliiseS @erikerikson