Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto reviewer branch policy #71

Merged
merged 5 commits into from
Jul 14, 2020

Conversation

C123R
Copy link
Contributor

@C123R C123R commented Jul 12, 2020

Signed-off-by: Cizer Pereira mail@cizer.dev

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number: #29

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@C123R C123R changed the title Feat/auto reviewer feat/auto reviewer Jul 12, 2020
@C123R C123R changed the title feat/auto reviewer feat: Auto reviewer branch policy Jul 12, 2020
@ghost ghost added size/L and removed size/XL labels Jul 14, 2020
@EliiseS EliiseS merged commit ef7f434 into microsoft:master Jul 14, 2020
@EliiseS
Copy link
Member

EliiseS commented Jul 14, 2020

@C123R Thank you!

@C123R
Copy link
Contributor Author

C123R commented Jul 14, 2020

@C123R Thank you!

Awesome, @EliiseS Thanks for your support :)

Btw, there are other branch policies which we could add it as a resource. Should I create an issue first or directly come up with the PR?

@C123R C123R deleted the feat/auto-reviewer branch July 14, 2020 15:46
@EliiseS
Copy link
Member

EliiseS commented Jul 14, 2020

@C123R An issue first, but more as a place of documentation, such as links to the API docs and design discussion 😄
Feel free to start working on it right away, just make a comment on the issue saying you're picking it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants