ClassCleanup declared on a base type not correctly triggered

[3s-ap]

Description

When the ClassCleanup attribute is declared on a base type with ClassCleanupBehavior.EndOfClass, it still triggered at end of assembly.

Steps to reproduce

Run this code:

[TestClass]
public class TestClassBase
{
	[ClassInitialize(InheritanceBehavior.BeforeEachDerivedClass)]
	public static void BeforeClsBase(TestContext testContext)
	{
		Log.Message("ClassInitialize - TestClassBase");
	}

	[ClassCleanup(InheritanceBehavior.BeforeEachDerivedClass, ClassCleanupBehavior.EndOfClass)]
	public static void AfterClsBase()
	{
		Log.Message("ClassCleanup - TestClassBase");
	}
}

[TestClass]
public class TestClassDerivedA : TestClassBase
{
	[TestMethod]
	public void TestMethod()
	{
		Log.Message("Test Method A");
	}
}

[TestClass]
public class TestClassDerivedB : TestClassBase
{
	[TestMethod]
	public void TestMethod()
	{
		Log.Message("Test Method B");
	}
}

Expected behavior

ClassCleanup is triggered at the end of class, according to 'ClassCleanupBehavior.EndOfClass'

Actual behavior

Log output:

ClassInitialize - TestClassBase
Test Method A
ClassInitialize - TestClassBase
Test Method B
ClassCleanup - TestClassBase
ClassCleanup - TestClassBase

Environment

VS 2019
MSTest.TestAdapter: 2.2.10
MSTest.TestFramework: 2.2.10

AB#1677601

[Evangelink]

Hi @3s-ap! Thank you for reporting this issue! I have managed to reproduce the behavior.

[Evangelink]

@engyebrahim This issue is somehow related to the various fixes you are doing on init and cleanup methods. Could you please investigate it after you are done with your refactoring?

[engyebrahim]

Hi @3s-ap! I tried to reproduce the issue using V2.2.10 using TestContext and Console.Write but the messages' order was different than the ones you had.

1. using TestContext the cleanup logs don't appear.
2. using Console.Write the cleanup appear at the beginning.

So please can you upload the whole repo to use the log.message() you used in your investigation? Or did you try to use one of the ways I used?

[3s-ap]

Hi @engyebrahim,

I attached a small lib that reproduces the issue. Please inspect the 'bin\debug\net48\log.txt' file after you run all tests.

sources.zip

[Evangelink]

@3s-ap v3.0.1 is now released, feel free to give it a go and get back to us if you find anything wrong.