Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer: Ensure to use Microsoft.VisualStudio.TestTools.UnitTesting.DescriptionAttribute and not System.ComponentModel.DescriptionAttribute #2949

Closed
fforjan opened this issue May 24, 2024 · 3 comments · Fixed by #3202
Closed

Analyzer: Ensure to use Microsoft.VisualStudio.TestTools.UnitTesting.DescriptionAttribute and not System.ComponentModel.DescriptionAttribute #2949

fforjan opened this issue May 24, 2024 · 3 comments · Fixed by #3202
Assignees
@engyebrahim
Labels
Area: Analyzers sprint Type: Feature
Milestone
MSTest 3.5 / Plat...

Comments

@fforjan
Copy link

fforjan commented May 24, 2024 •
edited by pavelhorak
Loading

It is very easy to use System.ComponentModel.Description instead of a Microsoft.VisualStudio.TestTools.UnitTesting attribute.
Having an analyzer which ensure that on a TestMethod we use the right attribute will be good.

AB#2079032
@fforjan fforjan changed the title Analyzer: Ensure to use Microsoft.VisualStudio.TestTools.UnitTesting and not System.ComponentModel.Description Analyzer: Ensure to use Microsoft.VisualStudio.TestTools.UnitTesting.DescriptionAttribute and not System.ComponentModel.DescriptionAttribute May 24, 2024
@Evangelink
Copy link
Member

Yeah good idea!

@Evangelink Evangelink added Help-Wanted The issue is up-for-grabs, and can be claimed by commenting Type: Feature Area: Analyzers and removed Needs: Triage 🔍 labels May 24, 2024
@Evangelink Evangelink added this to the 3.6.0 milestone May 24, 2024
@nohwnd
Copy link
Member

nohwnd commented May 27, 2024

This is great. I was hit by them same just this week.

@engyebrahim engyebrahim self-assigned this Jun 4, 2024
This was referenced Jul 2, 2024
Merged
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Help-Wanted The issue is up-for-grabs, and can be claimed by commenting label Jul 3, 2024
@fforjan
Copy link
Author

fforjan commented Jul 3, 2024

awesome, cannot wait for next release,
Thanks @engyebrahim and @Evangelink !

@Evangelink Evangelink modified the milestones: 3.6.0, 3.5.0 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engyebrahim engyebrahim

Labels
Area: Analyzers sprint Type: Feature
Projects
None yet
Milestone
MSTest 3.5 / Platform 1.3
4 participants
@fforjan @nohwnd @Evangelink @engyebrahim