Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ConcurrentDictionary for attribute cache #3042

Closed
nohwnd opened this issue May 30, 2024 · 0 comments · Fixed by #3061 or #3062
Closed

Use ConcurrentDictionary for attribute cache #3042

nohwnd opened this issue May 30, 2024 · 0 comments · Fixed by #3061 or #3062
Assignees
@nohwnd
Labels
Area: Performance Type: Chore

Comments

@nohwnd
Copy link
Member

nohwnd commented May 30, 2024

Evangelink 2 days ago
What about using ConcurrentDictionary instead?

Member
Author
@nohwnd nohwnd 2 days ago
I was thinking about it I wanted to measure the impact once this is merged, I saw time spent in locks in PerfView, but it also was not significantly faster without any locks. So please merge this approach first.

Member
Author
@nohwnd nohwnd 26 minutes ago
I was also thinking about writer only lock, but I am not sure if concurrent dictionary does not do that for me automatically already.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nohwnd nohwnd

Labels
Area: Performance Type: Chore
Projects
None yet
Milestone
No milestone
2 participants
@nohwnd @Evangelink