Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tfx extension publish shows incorrect "sharing" status #74

Open
willsmythe opened this issue Feb 10, 2016 · 4 comments
Open

tfx extension publish shows incorrect "sharing" status #74

willsmythe opened this issue Feb 10, 2016 · 4 comments

Comments

@willsmythe
Copy link
Contributor

Just updated a public extension, tfx extension publish shows this after publishing:

=== Completed operation: publish extension ===

  • Packaging: XXXXX
  • Publishing: success
    * - Sharing: not shared (use --share-with to share)*

I have also updated private extensions and it incorrectly indicates the extension is not shared, even though it has previously (and is currently) shared with multiple accounts.

@willsmythe
Copy link
Contributor Author

@trevorsg - can you take a look?

@T-Hugs
Copy link
Contributor

T-Hugs commented Feb 10, 2016

I suppose if it's public, we should omit the Sharing feedback since that
doesn't really make sense.

On Wed, Feb 10, 2016 at 1:39 PM, Will Smythe notifications@github.com
wrote:

@trevorsg https://github.com/trevorsg - can you take a look?


Reply to this email directly or view it on GitHub
#74 (comment).

@willsmythe
Copy link
Contributor Author

Yah. And on an 'update' of a private extension, consider just querying the server to see how many accounts the extension is shared with and then report whatever this number is.

@T-Hugs
Copy link
Contributor

T-Hugs commented Feb 10, 2016

Ah, makes sense.

On Wed, Feb 10, 2016 at 1:57 PM, Will Smythe notifications@github.com
wrote:

Yah. And on an 'update' of a private extension, consider just querying the
server to see how many accounts the extension is shared with and then
report whatever this number is.


Reply to this email directly or view it on GitHub
#74 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants