Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes needed to be able to install on osx #148

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kashzonal
Copy link

Changes needed to be able to run sudo npm install -g tfx-cli

I had to remove certain dependencies not compatible with osx, build locally for node.js to accept the app as valid

Removal of `@type` dependencies as this does seem to work on local install.
@T-Hugs
Copy link
Contributor

T-Hugs commented Sep 20, 2016

Can you provide more information about what this PR is trying to do? We definitely don't want to check in the compiled JS. Additionally, the @types dependencies shouldn't have any effect on install. From the log you posted, do you know why the message "Error: Refusing to install tfx-cli as a dependency of itself" is getting generated? Thanks.

@kashzonal
Copy link
Author

kashzonal commented Sep 20, 2016

It isn't meant to be merged onto the master branch. I created it to demonstrate what I had to do to be able to install on osx. I should have stated that. I do apologise.

@types dependencies are definately an issue with osx. I have attached the updated logs.

When I remove the @types dependencies as shown in the PR, node complains that the dir _build is not present.

So here are the steps I took to install tfx-cli

  1. Download the repo locally
  2. CD onto the downloaded folder
  3. Perform sudo npm install
  4. Run the scripts
  5. Commit the changes to git
  6. Run sudo npm install -g <GIT-ADDR>

The following two files need to be copied onto the build folder: package.json and tfx-cli.js.
I suspect that there is an issue with the build process on osx during the install.

As an aside, a token is always asked even if a password and username is set.
npm-debug.log.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants