-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup color compute #81
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
natoverse
commented
Nov 16, 2022
- Refactors color compute for better modularity and documentation. Includes removing the ColorMaker class in favor of a single function.
- Parameterizes all scheme compute constants so we can expose deep customization
- Improves public API consistency
- Improves the Vega API and mapping
- Updates the color matching function
- Adds better default params along with validation
- Adds a rainbow scale option
- Adds option to mix a hue into greyscales
- Adds option to tune the scale intensity
- Reserves the accent color for primary charts, excluding it from nominal scales
- Updates the webapp layout a bit to remove header clutter
dayesouza
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates are great! Just one comment that we talked about the cache being removed and the sliders freezing a little but it only happens when the graph visualization is open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.