Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup color compute #81

Merged
merged 29 commits into from
Nov 17, 2022
Merged

Cleanup color compute #81

merged 29 commits into from
Nov 17, 2022

Conversation

natoverse
Copy link
Contributor

  • Refactors color compute for better modularity and documentation. Includes removing the ColorMaker class in favor of a single function.
  • Parameterizes all scheme compute constants so we can expose deep customization
  • Improves public API consistency
  • Improves the Vega API and mapping
  • Updates the color matching function
  • Adds better default params along with validation
  • Adds a rainbow scale option
  • Adds option to mix a hue into greyscales
  • Adds option to tune the scale intensity
  • Reserves the accent color for primary charts, excluding it from nominal scales
  • Updates the webapp layout a bit to remove header clutter

Copy link
Contributor

@dayesouza dayesouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates are great! Just one comment that we talked about the cache being removed and the sliders freezing a little but it only happens when the graph visualization is open

@natoverse natoverse merged commit cd2c001 into main Nov 17, 2022
@natoverse natoverse deleted the cleanup-color-compute branch November 17, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants