Fix reading bool value using compact protocol

[reisub]

We came across an issue in deserializing a bool value using compact protocol - the value always comes out false.

This PR modifies the test so that it catches this bug and fixes it.

[msftclas]

@reisub,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

[codecov-io]

Codecov Report

Merging #153 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #153      +/-   ##
============================================
+ Coverage     65.45%   65.48%   +0.02%     
- Complexity      931      932       +1     
============================================
  Files            88       88              
  Lines          4806     4806              
  Branches        561      561              
============================================
+ Hits           3146     3147       +1     
  Misses         1423     1423              
+ Partials        237      236       -1

Impacted Files	Coverage Δ	Complexity Δ
...om/microsoft/thrifty/protocol/CompactProtocol.java	78.24% <100%> (ø)	63 <0> (ø)	⬇️
...in/java/com/microsoft/thrifty/schema/Location.java	78.04% <0%> (+2.43%)	16% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85ff3c7...8840ab3. Read the comment docs.

[msftclas]

@reisub, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

[benjamin-bader]

Excellent catch - thanks for the fix! Would you mind including the thrift change you made to Xtruct as well, so we don't lose it if/when we ever regenerate it?

[reisub]

@benjamin-bader done in 8840ab3, though I'm not sure which exact file you wanted changed since there are none in the thrift-runtime module.

[benjamin-bader]

Perfect. There's no one file, sadly - we seem to have overlooked automating generating this file, probably because it is done so infrequently. I think this would only be the second version.

I'm comfortable calling the integration-test file the "source of truth" here.

[benjamin-bader]

Merged - thanks again!