Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin codegen #183

Merged
merged 11 commits into from Jul 30, 2018
Merged

Conversation

benjamin-bader
Copy link
Collaborator

This PR implements Kotlin codegen of Thrift structures. It does everything except services, which need some more thinking. With that caveat, codegen itself is largely complete here, and just needs wiring up to thrifty-compiler to be usable from the command-line.

Still to-do before things are "shippable":

  • services (obvs)
  • wiring to thrifty-compiler
  • rethinking compiler plugins for Kotlin (kotlinpoet is not interoperable with javapoet)

I feel comfortable merging this in the current state, without making it available in the command-line app.

@codecov-io
Copy link

codecov-io commented Jul 28, 2018

Codecov Report

Merging #183 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #183      +/-   ##
===========================================
- Coverage     72.48%   72.4%   -0.09%     
  Complexity      373     373              
===========================================
  Files            30      30              
  Lines          1730    1732       +2     
  Branches        165     165              
===========================================
  Hits           1254    1254              
- Misses          378     380       +2     
  Partials         98      98
Impacted Files Coverage Δ Complexity Δ
...crosoft/thrifty/compiler/TypeProcessorService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...om/microsoft/thrifty/compiler/ThriftyCompiler.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d6116...14da5da. Read the comment docs.

@benjamin-bader benjamin-bader merged commit 75067bc into microsoft:master Jul 30, 2018
@benjamin-bader benjamin-bader deleted the kotlin-codegen branch July 30, 2018 03:42
accandme pushed a commit to accandme/thrifty that referenced this pull request Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants