New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin codegen #183
Merged
benjamin-bader
merged 11 commits into
microsoft:master
from
benjamin-bader:kotlin-codegen
Jul 30, 2018
Merged
Kotlin codegen #183
benjamin-bader
merged 11 commits into
microsoft:master
from
benjamin-bader:kotlin-codegen
Jul 30, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
===========================================
- Coverage 72.48% 72.4% -0.09%
Complexity 373 373
===========================================
Files 30 30
Lines 1730 1732 +2
Branches 165 165
===========================================
Hits 1254 1254
- Misses 378 380 +2
Partials 98 98
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Kotlin codegen of Thrift structures. It does everything except services, which need some more thinking. With that caveat, codegen itself is largely complete here, and just needs wiring up to
thrifty-compiler
to be usable from the command-line.Still to-do before things are "shippable":
I feel comfortable merging this in the current state, without making it available in the command-line app.