Add Okio-based convenience APIs to thrifty-runtime #408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds extensions to
BufferedSource
andBufferedSink
, making it easy to convert them into thriftyTransport
objects in a fluent style. It also adds fluent builders for makingProtocol
instances out ofTransport
instances. This lets us do the following:In contrast, before this PR one would have to either write a custom transport, or buffer the entire serialized message in memory:
The new code is about as brief as the old code, is more easily readable (IMO), and has the potential to be much more efficient in that it can partake in okio's segment-sharing and stream reads and writes rather than buffering entire messages into memory at once. In some real-world use cases this is a savings of MB per message of working memory.
It's clearly not hard to write these custom transports, but there's no need for everyone to have to do it themselves.