Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use libthrift 0.16 #465

Closed
wants to merge 1 commit into from
Closed

Conversation

jimexist
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Mar 31, 2022

CLA assistant check
All CLA requirements met.

@benjamin-bader
Copy link
Collaborator

Hey @jimexist, are you still interested in landing this, or have you moved on to apache thrift (which seems likely given your work on apache/thrift#2556)?

@jimexist
Copy link
Contributor Author

Hey @jimexist, are you still interested in landing this, or have you moved on to apache thrift (which seems likely given your work on apache/thrift#2556)?

hi @benjamin-bader thanks for asking - i intend to do so but not sure if it's aligned with the project direction. e.g. in Apache thrift there's also a mechanism to register metadata but I find it lacking in thrifty. Any plan of sharing a roadmap for thrifty, e.g. how it'll expand into non Android platform?

@benjamin-bader
Copy link
Collaborator

There's no roadmap whatsoever. What do you mean by "registering metadata"? I'm not familiar with that feature.

@jimexist
Copy link
Contributor Author

There's no roadmap whatsoever. What do you mean by "registering metadata"? I'm not familiar with that feature.

i was referring to the fact that all apache thrift generated structs, upon loading, will call:

https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/meta_data/FieldMetaData.java#L57-L59

to register field metadata, and then some of the frameworks will rely on this to meta-program clients/servers

@benjamin-bader
Copy link
Collaborator

Huh, interesting. Thanks for the pointer!

You asked about expanding Thrifty into non-android use cases. There's a nascent server implementation that @luqasn has contributed. It's based on Kotlin coroutines, so that's pretty neat. What it doesn't do is runtime reflection or introspection of the sort that metadata maps would enable. I don't personally have any plans to work in that direction, but wouldn't necessarily be opposed to accepting an implementation, should someone wish to contribute one.

(If you or anyone else does want to do that, let's work through the design in a new issue!)

@jimexist jimexist closed this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants