Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kotlin-codegen support for struct-valued constants #482

Conversation

benjamin-bader
Copy link
Collaborator

This is big enough that I'm leaving out more subtle questions of whether/how to enforce presence of optional fields or fields with default values, in deference to having a commit that is at least somewhat readable.

We'll settle that question prior to the next release.

@codecov-commenter
Copy link

Codecov Report

Merging #482 (7a77084) into master (d7d0998) will increase coverage by 0.25%.
The diff coverage is 68.57%.

@@             Coverage Diff              @@
##             master     #482      +/-   ##
============================================
+ Coverage     58.87%   59.12%   +0.25%     
- Complexity      864      865       +1     
============================================
  Files            69       69              
  Lines          6451     6481      +30     
  Branches       1004     1012       +8     
============================================
+ Hits           3798     3832      +34     
+ Misses         2360     2345      -15     
- Partials        293      304      +11     
Impacted Files Coverage Δ
...in/kotlin/com/microsoft/thrifty/schema/Constant.kt 78.88% <42.85%> (+0.35%) ⬆️
.../com/microsoft/thrifty/kgen/KotlinCodeGenerator.kt 84.61% <75.00%> (+0.50%) ⬆️
.../kotlin/com/microsoft/thrifty/schema/StructType.kt 45.83% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7d0998...7a77084. Read the comment docs.

@benjamin-bader benjamin-bader merged commit 6325d9c into microsoft:master Apr 16, 2022
@benjamin-bader benjamin-bader deleted the struct-constants-kotlin-codegen branch April 16, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants