update to latest azure spring boot release #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue related: microsoft/spring-data-cosmosdb#212 |
|
Please hold on this PR until Jenkins World demo finished by Step. 19th US time. BTW, I m not sure who is using this repo to do some demo, @Matthew-Dong Would u please send out a notification to the team? |
yuwzho
reviewed
Sep 7, 2018
| return new ResponseEntity<List<TodoItem>>(todoItemRepository.findAll(), HttpStatus.OK); | ||
| final Iterable<TodoItem> itemIterable = todoItemRepository.findAll(); | ||
| final List<TodoItem> items = new ArrayList<>(); | ||
| itemIterable.forEach(todoItem -> items.add(todoItem)); |
There was a problem hiding this comment.
Just curious why not returning the Iterable directly?
There was a problem hiding this comment.
This is an update according to API change, previously findAll returns List, while new version returns Iterable, just updated to remove the convert and the generics List<TodoItem> type.
sophiaso
changed the title
Matthew-Dong
approved these changes
Sep 21, 2018
|
Seems the Jenkins World is closed and Spring Data updated to fix some issues, I'll close and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.