Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One question about TOGA's implementation in data/atlas_star_datagen.py #5

Open
ghost opened this issue Mar 21, 2023 · 0 comments
Open

Comments

@ghost
Copy link

ghost commented Mar 21, 2023

Hi,
There is a regular expression in "toga/data/atlas_star_datagen.py"(Line 7):

split_re = re.compile("\"<AssertPlaceHolder>\" ;[ }]*")

I think you use this regular expression to separate a test method and a focal method in ATLAS' dataset. If test methods have statements or any other tokens following the marker "<AssertPlaceHolder>", these test methods cannot be matched by this regular expression. I think the correct version of Line 7 in atlas_star_datagen.py should be:

split_re = re.compile("\"<AssertPlaceHolder>\" .*?;( })+")

Could you let me know at your earliest convenience whether the above is my misunderstanding?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants