Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow getResolvedName to resolve QualifiedName in TraitUseClause #401

Merged
merged 2 commits into from
May 18, 2023
Merged

fix: Allow getResolvedName to resolve QualifiedName in TraitUseClause #401

merged 2 commits into from
May 18, 2023

Conversation

zobo
Copy link
Contributor

@zobo zobo commented May 16, 2023

Discussion in #400

roblourens
roblourens reviewed May 16, 2023
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The change is fine to me, but there are tests for this, so please update those too.

roblourens
roblourens reviewed May 16, 2023
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The change is fine to me, but there are tests for this, so please update those too.

@zobo
Copy link
Contributor Author

zobo commented May 16, 2023

Ah, managed to miss those due to all the noise running phpunit on windows. Will look at those asap.

@zobo
Copy link
Contributor Author

zobo commented May 16, 2023

@microsoft-github-policy-service agree

@roblourens roblourens enabled auto-merge May 18, 2023 01:19
@roblourens roblourens added this to the May 2023 milestone May 18, 2023
@roblourens roblourens merged commit a705c41 into microsoft:main May 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblourens roblourens roblourens approved these changes

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zobo @roblourens @DonJayamanne