-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Only skip unit test on MacOS and only on Github Actions (#38)
This commit Closes #35. We still don't know why the unit test `test_laplacian_embedding_elbowcut_none` fails on the MacOS Github Action instances, but not on any other MacOS system that we've tried. This fix addresses the issue by effectively ignoring it as we can't reproduce it elsewhere, but it took steps to make the test be skipped only on Github Actions, only when using the .github/workflows/validate_on_push.yml workflow file, and only as long as the SKIP_TEST_35=true environment variable is used when running the test. This means that developer/user testers of topologic with MacOS will still run this unit test, and we can also create a new branch to disable this flag and continue testing topologic + Github Actions on MacOS in an attempt to see when, or if, this is fixed (since it doesn't seem to be related to us so much as Github's CI instances). Co-authored-by: Dwayne Pryce <dwpryce@microsoft.com>
- Loading branch information
Dwayne Pryce
and
Dwayne Pryce
committed
Apr 1, 2020
1 parent
fd7b227
commit ed30cda
Showing
3 changed files
with
11 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters