Skip to content
This repository has been archived by the owner on Jul 11, 2024. It is now read-only.

Update ari_scores #10

Closed
nicaurvi opened this issue Feb 11, 2020 · 1 comment · Fixed by #23
Closed

Update ari_scores #10

nicaurvi opened this issue Feb 11, 2020 · 1 comment · Fixed by #23
Assignees

Comments

@nicaurvi
Copy link
Contributor

  • Move into a module called similarity at topologic.similarity
  • Add support for Jaccard similarity
  • Remove calculate_ari_scores function (no more enriched graphs)
@daxpryce daxpryce self-assigned this Feb 13, 2020
@daxpryce
Copy link
Contributor

After some more thought it doesn't make sense to use Jaccard at all; it's superficially a good choice to add but it doesn't inherently take into consideration label names changing, which is pretty much a guaranteed. I'm not sure jaccard would make sense for any of the comparisons we're trying to do re: cluster or partition membership as a result of our embedding clustering algorithms or our global partitioning algorithms.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants