Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset plotting #587

Closed
calebrob6 opened this issue Jun 16, 2022 · 5 comments
Closed

Dataset plotting #587

calebrob6 opened this issue Jun 16, 2022 · 5 comments
Labels
datasets Geospatial or benchmark datasets dependencies Packaging and dependencies

Comments

@calebrob6
Copy link
Member

Some of our datasets (idtrees?) are plotting (H, W, 1) images, can we just squash these so we can support older versions of matplotlib?

@calebrob6 calebrob6 added datasets Geospatial or benchmark datasets dependencies Packaging and dependencies labels Jun 16, 2022
@isaaccorley
Copy link
Collaborator

I'm guessing this is regarding the idtrees CHM data which gets plotted with a colormap? If it works then we should squeeze the singleton dim.

@adamjstewart
Copy link
Collaborator

@isaaccorley is this still an issue? If I remember correctly, this was discovered when I started testing our datamodules with real trainers and found that I needed to increase the minimum matplotlib version in order to plot (H, W, 1) images. Not sure if we should fix this and lower our matplotlib version requirement or just close this issue, but I don't want to ignore it forever.

@isaaccorley
Copy link
Collaborator

Looks like we didn't squeeze the singleton dimension for the CHM data when plotting. It looks like it would only be a one line change. Is this something you want to do so we can revert the matplotlib version change that was made?

@adamjstewart
Copy link
Collaborator

If it's that easy might as well try it and see if it works. Can't remember if there were other datasets that required this.

@adamjstewart
Copy link
Collaborator

I think we can close this, I'm not worried about supporting ancient matplotlib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets dependencies Packaging and dependencies
Projects
None yet
Development

No branches or pull requests

3 participants