Bump mypy from 0.991 to 1.0.0 in /requirements #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [mypy](https://github.com/python/mypy) from 0.991 to 1.0.0. - [Release notes](https://github.com/python/mypy/releases) - [Commits](python/mypy@v0.991...v1.0.0) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
github-actions
bot
added
datasets
adamjstewart
reviewed
Feb 6, 2023
| @@ -119,7 +119,7 @@ def run_eval_loop( | |||
| } | |||
| for i in range(len(batch["image"])) | |||
| ] | |||
| with torch.inference_mode(): | |||
| with torch.inference_mode(): # type: ignore[no-untyped-call] | |||
There was a problem hiding this comment.
adamjstewart
reviewed
Feb 6, 2023
| @@ -143,7 +143,6 @@ def main(args: argparse.Namespace) -> None: | |||
| # Loads the saved model from checkpoint based on the `args.task` name that was | |||
| # passed as input | |||
| model = TASK.load_from_checkpoint(args.input_checkpoint) | |||
| model = cast(pl.LightningModule, model) | |||
There was a problem hiding this comment.
mypy now supports Self, so many of our PL typing bugs have been fixed.
github-actions
bot
added
the
documentation
adamjstewart
approved these changes
Feb 6, 2023
calebrob6
pushed a commit
that referenced
this pull request
Apr 10, 2023
* Bump mypy from 0.991 to 1.0.0 in /requirements Bumps [mypy](https://github.com/python/mypy) from 0.991 to 1.0.0. - [Release notes](https://github.com/python/mypy/releases) - [Commits](python/mypy@v0.991...v1.0.0) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump upper bound * mypy fixes * Ignore undocumented base class --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* Bump mypy from 0.991 to 1.0.0 in /requirements Bumps [mypy](https://github.com/python/mypy) from 0.991 to 1.0.0. - [Release notes](https://github.com/python/mypy/releases) - [Commits](python/mypy@v0.991...v1.0.0) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump upper bound * mypy fixes * Ignore undocumented base class --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps mypy from 0.991 to 1.0.0.
Commits
bc18017Promote 1.0.0+dev to 1.0.0 (#14594)c2876bf[1.0 backport] [used before def] add documentation (#14592) (#14597)8ef98ccVarious documentation and error message tweaks (#14574)9aa1776Improve Generics docs page (#14587)cb2ec3dImprove protocols documentation (#14577)2cfc46cImprove the Common Issues page (#14581)7cf1391Make a top-level TypedDict page (#14584)dd2c9a6Improve some dynamic typing docs (#14576)a6dce84Upgrade to tox v4 (#14579)eb2e02dFix passenv for tox 4 (#14578)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)