CI: test notebooks when modified #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
|
Error msg is useless: treebeardtech/nbmake#80 |
|
This is prob safe to merge. One of the tutorials doesn't pass, and hasn't passed for a very long time, but we're still trying to figure out why. By having separate tests for these files, it should be easier to debug and iterate on. Once this is merged, I have several ideas for how we can speed up the tests. |
isaaccorley
approved these changes
Feb 16, 2023
calebrob6
pushed a commit
that referenced
this pull request
Apr 10, 2023
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our notebooks were only tested when creating a release, which made it difficult to add or modify tutorials. With this PR, our notebooks are now also tested when modified.
Unfortunately it doesn't seem possible to reuse the tests in
releases.yaml, we have to duplicate them: https://github.com/orgs/community/discussions/46680.