Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trainers: fix support for non-TensorBoardLogger #1145

Merged
merged 3 commits into from
Feb 25, 2023
Merged

Conversation

adamjstewart
Copy link
Collaborator

@adamjstewart adamjstewart commented Feb 25, 2023

Fixes #1143

Can be tested by running the pretrained weights or trainers tutorials and replacing:

pip install torchgeo

with

pip install git+https://github.com/microsoft/torchgeo.git@fixes/csv-logger

@adamjstewart adamjstewart added this to the 0.4.1 milestone Feb 25, 2023
@github-actions github-actions bot added the trainers PyTorch Lightning trainers label Feb 25, 2023
@adamjstewart adamjstewart marked this pull request as ready for review February 25, 2023 18:04
@adamjstewart adamjstewart changed the title Trainers: fix support for CSVLogger Trainers: fix support for non-TensorBoardLogger Feb 25, 2023
@adamjstewart adamjstewart merged commit be9d25c into main Feb 25, 2023
@adamjstewart adamjstewart deleted the fixes/csv-logger branch February 25, 2023 22:39
calebrob6 pushed a commit that referenced this pull request Apr 10, 2023
* Trainers: fix support for CSVLogger

* No need to check truthiness of attr

* Revert "No need to check truthiness of attr"

This reverts commit 450df6c.
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Trainers: fix support for CSVLogger

* No need to check truthiness of attr

* Revert "No need to check truthiness of attr"

This reverts commit 450df6c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trainers PyTorch Lightning trainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorials: issue with trainer and logger?
2 participants