Landsat: better default bands #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjstewart
commented
Mar 10, 2023
| rgb_bands = ["SR_B4", "SR_B3", "SR_B2"] | ||
|
|
||
|
|
||
| class Landsat9(Landsat8): | ||
| """Landsat 9 Operational Land Imager (OLI) and Thermal Infrared Sensor (TIRS).""" | ||
| """Landsat 9 Operational Land Imager (OLI-2) and Thermal Infrared Sensor (TIRS-2).""" # noqa: E501 |
There was a problem hiding this comment.
Black and pydocstyle require one-line docstrings to have the closing quotes on the same line, but flake8 complains that the line is too long. So we have to ignore the latter in order to appease the former.
isaaccorley
approved these changes
Mar 20, 2023
calebrob6
pushed a commit
that referenced
this pull request
Apr 10, 2023
* Landsat: better default bands * Correct name of sensors on Landsat 9 * black/pydocstyle/flake8 fix * MSS does not have SR, at least on GEE
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* Landsat: better default bands * Correct name of sensors on Landsat 9 * black/pydocstyle/flake8 fix * MSS does not have SR, at least on GEE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Landsat, B8–B11 only exist for raw imagery and top of atmosphere reflectance, not surface reflectance. I still think it makes sense to default to surface reflectance, but we should not include bands that don't exist for it.
At least on Google Earth Engine (GEE), Landsat 1–5 Multispectral Scanner (MSS) do not have surface reflectance, so default to the band names for raw imagery.
References: