Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lightning imports #1179

Merged
merged 2 commits into from
Mar 19, 2023
Merged

Fix lightning imports #1179

merged 2 commits into from
Mar 19, 2023

Conversation

adamjstewart
Copy link
Collaborator

Follow-up to #1178

Although some things (LightningModule, LightningDataModule, Trainer) get import aliases at the lightning level, most other things (callbacks, loggers) don't. Even for things with import aliases, the docs still recommend importing them at the lightning.pytorch level. Let's stick with that everywhere for consistency.

@adamjstewart adamjstewart added this to the 0.4.1 milestone Mar 16, 2023
@github-actions github-actions bot added datamodules PyTorch Lightning datamodules documentation Improvements or additions to documentation scripts Training and evaluation scripts testing Continuous integration testing trainers PyTorch Lightning trainers labels Mar 16, 2023
@adamjstewart adamjstewart merged commit e8b9a9e into main Mar 19, 2023
@adamjstewart adamjstewart deleted the fixes/lightning branch March 19, 2023 16:48
calebrob6 pushed a commit that referenced this pull request Apr 10, 2023
* Fix lightning imports

* Style fixes
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Fix lightning imports

* Style fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodules PyTorch Lightning datamodules documentation Improvements or additions to documentation scripts Training and evaluation scripts testing Continuous integration testing trainers PyTorch Lightning trainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants