SeCo newer version bug fix #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaaccorley
force-pushed
the
seco/dir_list_bug
branch
from
7357787
to
b47c62a
Compare
|
Can you update the test data? It could also be that the 100K version has a different layout than the 1M version. I think that was the case with SSL4EO-S12 too. |
adamjstewart
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may have a new version of SeCo downloaded, but each patch directory in the version I have contains RGB tifs + directories with individual band tifs. for example the folder
seasonal_contrast_100k/01999contains the following:I think the current dataset expects there to not be RGB tifs. This simple fix makes it so that it ignores the RGB tifs since we load RGB bands with the individual band files anyway.