Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SustainBench Crop Yield Dataset #1253

Merged
merged 15 commits into from
Apr 20, 2023
Merged

Add SustainBench Crop Yield Dataset #1253

merged 15 commits into from
Apr 20, 2023

Conversation

nilsleh
Copy link
Collaborator

@nilsleh nilsleh commented Apr 17, 2023 •
edited

This PR adds the Sustainbench Crop Yield Dataset as a dataset with a corresponding datamodule.

Dataset Format:

  • .npz file of stacked samples

Dataset Features:

  • MODIS band histograms across time with regression target of soybean yield in metric tonnes

Questions:

  • the dataloading from the .nzp files seems quiet slow, as it always has to index the .npz files but I am not sure how to speed it up

Example:

@github-actions github-actions bot added datamodules PyTorch Lightning datamodules datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing labels Apr 17, 2023
@adamjstewart adamjstewart added this to the 0.5.0 milestone Apr 17, 2023
adamjstewart
adamjstewart requested changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of inconsistencies in naming. Need to decide between SustainBenchCropYield and SustainBenchCropYieldPrediction (I prefer the former because it's shorter). Also it should be SustainBench, not Sustainbench.

docs/api/datamodules.rst Outdated Show resolved Hide resolved
torchgeo/datamodules/sustainbench_crop_yield_prediction.py Outdated Show resolved Hide resolved
torchgeo/datasets/sustainbench_crop_yield_prediction.py Outdated Show resolved Hide resolved
@adamjstewart adamjstewart changed the title Add Sustainbench Crop Yield Dataset Add SustainBench Crop Yield Dataset Apr 19, 2023
adamjstewart
adamjstewart reviewed Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a bunch of directories and filenames containing "prediction"

adamjstewart
adamjstewart reviewed Apr 19, 2023
View reviewed changes
torchgeo/datamodules/sustainbench_crop_yield.py Outdated Show resolved Hide resolved
torchgeo/datamodules/sustainbench_crop_yield.py Outdated Show resolved Hide resolved
torchgeo/datasets/sustainbench_crop_yield.py Outdated Show resolved Hide resolved
torchgeo/datasets/sustainbench_crop_yield.py Outdated Show resolved Hide resolved
adamjstewart
adamjstewart previously approved these changes Apr 19, 2023
View reviewed changes
@adamjstewart
Copy link
Collaborator

Can you rebase?

@adamjstewart adamjstewart merged commit d03c6e1 into microsoft:main Apr 20, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
datamodules PyTorch Lightning datamodules datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nilsleh @adamjstewart