Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL4EO-L: add download support #1424

Merged
merged 7 commits into from
Jun 20, 2023

Conversation

adamjstewart
Copy link
Collaborator

Preliminary download support for SSL4EO-L. Still need to test to make sure it works on the real dataset.

@adamjstewart adamjstewart added this to In progress in SSL4EO-L via automation Jun 17, 2023
@github-actions github-actions bot added datasets Geospatial or benchmark datasets testing Continuous integration testing labels Jun 17, 2023
torchgeo/datasets/ssl4eo.py Outdated Show resolved Hide resolved
torchgeo/datasets/ssl4eo.py Show resolved Hide resolved
@adamjstewart adamjstewart marked this pull request as draft June 17, 2023 03:12
with open(path, "wb") as f:
for suffix in self.checksums[self.split]:
with open(path + suffix, "rb") as g:
while chunk := g.read(chunk_size):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first time using assignment expressions, such a neat feature!

@adamjstewart adamjstewart marked this pull request as ready for review June 18, 2023 16:35
@calebrob6
Copy link
Member

This looks good to me as long as you check that it works with the real dataset

@adamjstewart
Copy link
Collaborator Author

Yep, I checked

@adamjstewart adamjstewart merged commit 38be536 into microsoft:main Jun 20, 2023
21 checks passed
SSL4EO-L automation moved this from In progress to Done Jun 20, 2023
@adamjstewart adamjstewart deleted the datasets/ssl4eo-l branch June 20, 2023 16:54
@adamjstewart adamjstewart added this to the 0.5.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets testing Continuous integration testing
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants