DataModules: improve error messages #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjstewart
changed the title
nilsleh
reviewed
Jun 30, 2023
nilsleh
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1307
This implementation defines two new helper functions:
_valid_attribute: checks if at least one of the datasets or samplers has length > 0_dataloader_factory: defines a*_dataloaderdepending on the splitThe former handles all error messages and provides more specific and helpful error messages. Another bonus is that we avoid the majority of code duplication in these base classes, chopping off 30+ lines of code.
@yichiac I know you've run into this error message too many times, hopefully this will help with debugging.