-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality for validation split #1540
Conversation
@microsoft-github-policy-service agree |
Can we call it "val" instead of "valid"? That's what most other datasets call it. |
changed "valid" to "val", as per convention. |
Still a lot of failing tests, see https://torchgeo.readthedocs.io/en/stable/user/contributing.html for tips to fix these. |
Hi @adamjstewart, sorry for late reply. I was occupied with my thesis project. I am working on the feedback you have provided. |
@Tarandeep97 no worries, I also just finished my thesis. Hope everything went okay! |
@adamjstewart yes everything went well. Thank you. Hope, your thesis also went great. I have made few changes in the file, as per your feedback. I followed checklist provided here. |
I made the regex a bit simpler and got the tests working, let me know what you think! |
This looks perfect to me @adamjstewart . Thank you for helping! |
Closes #654: Implement Inria Dataset Validation Set Split
Summary:
This pull request addresses issue #654, which involves implementing the validation set split for the Inria dataset as specified in the contest guidelines (https://project.inria.fr/aerialimagelabeling/contest/).
Changes Made:
Added functionality to the
inria.py
file.Details:
Modified the
inria.py
file to implement the validation set split. The first five images of each location can now be removed by setting split argument to valid.