Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality for validation split #1540

Merged
merged 13 commits into from
Sep 29, 2023

Conversation

Tarandeep97
Copy link
Contributor

@Tarandeep97 Tarandeep97 commented Sep 1, 2023

Closes #654: Implement Inria Dataset Validation Set Split

Summary:
This pull request addresses issue #654, which involves implementing the validation set split for the Inria dataset as specified in the contest guidelines (https://project.inria.fr/aerialimagelabeling/contest/).

Changes Made:
Added functionality to the inria.py file.

Details:
Modified the inria.py file to implement the validation set split. The first five images of each location can now be removed by setting split argument to valid.

@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Sep 1, 2023
@Tarandeep97
Copy link
Contributor Author

@microsoft-github-policy-service agree

@adamjstewart
Copy link
Collaborator

Can we call it "val" instead of "valid"? That's what most other datasets call it.

@adamjstewart adamjstewart added this to the 0.5.0 milestone Sep 1, 2023
@Tarandeep97
Copy link
Contributor Author

changed "valid" to "val", as per convention.

@adamjstewart
Copy link
Collaborator

Still a lot of failing tests, see https://torchgeo.readthedocs.io/en/stable/user/contributing.html for tips to fix these.

@Tarandeep97
Copy link
Contributor Author

Hi @adamjstewart, sorry for late reply. I was occupied with my thesis project. I am working on the feedback you have provided.

@adamjstewart
Copy link
Collaborator

@Tarandeep97 no worries, I also just finished my thesis. Hope everything went okay!

@adamjstewart adamjstewart removed this from the 0.5.0 milestone Sep 28, 2023
@Tarandeep97
Copy link
Contributor Author

Tarandeep97 commented Sep 29, 2023

@adamjstewart yes everything went well. Thank you. Hope, your thesis also went great.

I have made few changes in the file, as per your feedback. I followed checklist provided here.
I investigated that test cases written fails when we try to fetch files other than austin[1-5].tif. I think this is because of /tests/data/inria/data.py file that generates sample dataset. Even though I tried making changes to /tests/data/inria/data.py, it continues generating same set of images. I tried clearing pytest cache, but it didn't work.
Can you help me guide further, how to fix this problem?

@adamjstewart adamjstewart added this to the 0.5.0 milestone Sep 29, 2023
@github-actions github-actions bot added the testing Continuous integration testing label Sep 29, 2023
@adamjstewart
Copy link
Collaborator

I made the regex a bit simpler and got the tests working, let me know what you think!

@adamjstewart adamjstewart added the backwards-incompatible Changes that are not backwards compatible label Sep 29, 2023
@github-actions github-actions bot added the datamodules PyTorch Lightning datamodules label Sep 29, 2023
@Tarandeep97
Copy link
Contributor Author

This looks perfect to me @adamjstewart . Thank you for helping!

@adamjstewart adamjstewart merged commit 6ae0d78 into microsoft:main Sep 29, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatible Changes that are not backwards compatible datamodules PyTorch Lightning datamodules datasets Geospatial or benchmark datasets testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inria dataset validation set
2 participants