Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add podcast episode #1806

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Conversation

adamjstewart
Copy link
Collaborator

Not sure why we didn't already have a link to this. I just rewatched it and it's still largely up to date.

Also changed our paper link to the arXiv version, which is easier to read for free. We still suggest citing the ACM version though.

@robmarkcole

@adamjstewart adamjstewart added this to the 0.5.2 milestone Jan 13, 2024
@robmarkcole
Copy link
Contributor

It is possible to embed the YouTube in the readme, if of interest

@robmarkcole
Copy link
Contributor

@adamjstewart
Copy link
Collaborator Author

Up to @calebrob6 if he wants his face on the README

@robmarkcole
Copy link
Contributor

It will display the video thumbnail,which can be whatever you like

nilsleh
nilsleh previously approved these changes Jan 21, 2024
@calebrob6
Copy link
Member

I don't mind my face there, but I'd rather not have just my face there -- if we have a few more videos with different people then I'm down to include the thumbnails.

I have had this bad assumption that tutorial videos aren't that useful as I don't ever specifically search/click through to youtube tutorials for programming topics (strongly prefer articles/notebooks). However, Qiusheng Wu's videos are great and get a ton of traffic and I've gotten several email questions about this video https://www.youtube.com/watch?v=R_FhY8aq708

@adamjstewart
Copy link
Collaborator Author

How does this look? https://github.com/adamjstewart/torchgeo/tree/docs/readme?tab=readme-ov-file#documentation

Unfortunately GitHub README files don't support embeddings, but could take screenshots like:
Screenshot 2024-01-22 at 12 14 39
and use those images instead so it's more clear that it's clickable.

@calebrob6
Copy link
Member

calebrob6 commented Jan 26, 2024

I can actually see it if I click on the README.md file itself, but I don't want only my face. I.e. if my face is there then yours should be too 😉 .

See https://github.com/adamjstewart/torchgeo/blob/docs/readme/README.md

image

@adamjstewart
Copy link
Collaborator Author

I don't yet have any videos with my face to share. I'm not worried about getting credit, I'll prob give an updated talk with @robmarkcole someday (maybe after we finish the next big exciting project and add some cool new features). Once we do that, we can add that video as well. I do think pictures of the videos are better than no pictures, although I really wish we could use the full embedded view that makes it clear it's clickable. Just need to decide where to store the images.

@robmarkcole
Copy link
Contributor

Another option is to make a completely new video, just a quick intro to torchgeo, and use that

@adamjstewart
Copy link
Collaborator Author

I might have time for that in about a month 😆

Could also change the thumbnail to remove Caleb's face, but I personally think it looks good 😉. Shows that the library is developed by humans, not companies. As long as Caleb doesn't get all the blame when something is broken.

@calebrob6
Copy link
Member

calebrob6 commented Feb 22, 2024

I need to get my camera setup sorted. Otherwise, this is fine.

@adamjstewart adamjstewart merged commit ddb4958 into microsoft:main Feb 22, 2024
24 checks passed
isaaccorley pushed a commit that referenced this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants