Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default folds and assertion for checking valid folds in PASTIS #1810

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

calebrob6
Copy link
Member

The unique folds in the metadata.geojson file in the PASTIS dataset are {1,2,3,4,5}.

@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Jan 16, 2024
@github-actions github-actions bot added the testing Continuous integration testing label Jan 16, 2024
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@adamjstewart adamjstewart added this to the 0.5.2 milestone Jan 16, 2024
@adamjstewart adamjstewart merged commit 436baa9 into main Jan 16, 2024
21 checks passed
@adamjstewart adamjstewart deleted the pastis_fix branch January 16, 2024 12:26
isaaccorley pushed a commit that referenced this pull request Mar 2, 2024
#1810)

* Fix the default folds and assertion for checking valid folds in PASTIS

* Maybe fix PASTIS tests

* Update data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants