Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deterministic group_shuffle_split #1839

Merged
merged 14 commits into from
Feb 28, 2024
Merged

Fix deterministic group_shuffle_split #1839

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
23ac1a4
order sets
nilsleh Jan 31, 2024
1c39cf7
suggestion
nilsleh Jan 31, 2024
a262b9f
add unit test
nilsleh Feb 26, 2024
cc4d24c
fix
nilsleh Feb 26, 2024
b107e41
updated test
nilsleh Feb 26, 2024
48cff20
fix
nilsleh Feb 26, 2024
acc314a
indices from file
nilsleh Feb 26, 2024
4e145fa
test util update
nilsleh Feb 26, 2024
01a9a6d
path
nilsleh Feb 26, 2024
8d797dd
no file
nilsleh Feb 28, 2024
6d0a531
no file
nilsleh Feb 28, 2024
8618293
merge main
nilsleh Feb 28, 2024
c436d02
comment
nilsleh Feb 28, 2024
69c6bd7
i cannot spell
nilsleh Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion torchgeo/datamodules/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,9 @@ def group_shuffle_split(
)

generator = np.random.default_rng(seed=random_state)
ordered_list = sorted(list(group_vals))
adamjstewart marked this conversation as resolved.
Show resolved Hide resolved
train_group_vals = set(
generator.choice(list(group_vals), size=n_train_groups, replace=False)
generator.choice(ordered_list, size=n_train_groups, replace=False)
)

train_idxs = []
Expand Down