xView2: deterministic dataset order #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think for this case this isn't as big of an issue because the train/test sets are in separate folders. But if you did random split the train set into a train/val set you would encounter issues with determinism due to the set operation. |
isaaccorley
approved these changes
Feb 28, 2024
|
You still have issues with determinism even without random split. The order you iterate over the dataset changes, so you can't reproduce training results. |
|
Train dataloaders random shuffle by default on each epoch, but yeah if you want to guarantee that that randomness is identical per seed, this definitely needs to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only other place I found where we're using a set. @RitwikGupta maybe you can confirm that dataset order is not deterministic (even with setting a random seed) and confirm that this fixes it?