Add LoveDA dataset #270
Merged
Add LoveDA dataset #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ashnair1
reviewed
Dec 7, 2021
ashnair1
reviewed
Dec 7, 2021
ashnair1
reviewed
Dec 7, 2021
ashnair1
reviewed
Dec 7, 2021
ashnair1
reviewed
Dec 7, 2021
ashnair1
reviewed
Dec 7, 2021
ashnair1
reviewed
Dec 7, 2021
|
Hi @nilsleh and thanks for the contribution! I know that the GID-15 didn't have this, but could you add a plot method and show some examples in the PR description? We are working on adding these to all datasets for visually verifying the image and labels were loaded correctly. |
ashnair1
reviewed
Dec 7, 2021
adamjstewart
reviewed
Dec 7, 2021
isaaccorley
reviewed
Dec 8, 2021
isaaccorley
reviewed
Dec 8, 2021
calebrob6
previously approved these changes
Dec 8, 2021
isaaccorley
requested changes
Dec 8, 2021
isaaccorley
requested changes
Dec 8, 2021
adamjstewart
reviewed
Dec 8, 2021
adamjstewart
approved these changes
Dec 8, 2021
adamjstewart
requested changes
Dec 8, 2021
I am not sure why the documentation is not picking up the correct return type for get_item and plot method, those two are causing the sphinx test to fail. |
|
Sometimes the sphinx test will fail. We can re run by closing and opening the PR. If not then maybe an update to packages broke it. |
adamjstewart
requested changes
Dec 9, 2021
adamjstewart
reviewed
Dec 9, 2021
adamjstewart
previously approved these changes
Dec 9, 2021
calebrob6
approved these changes
Dec 9, 2021
adamjstewart
approved these changes
Dec 9, 2021
isaaccorley
approved these changes
Dec 9, 2021
adamjstewart
added
datamodules
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* initial commit, adding LoveDA dataset * recommended changes by ashnair1 * corrections from pydocstyle linter * List[str] * plotting method added * linting test changes * passing test for plotting * linting adjustments * smaller fake data of 2x2 and mypy linter changes * plot only single image and mypy changes * plot method without expecting batch dimension * style changes and adding doc * added lightning data module * sphinx changes * doc string changes * data module in init and fake data for module test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposal for adding the LoveDA dataset that Caleb Robinson recommended me to look at as a contribution. This is my first time trying to contribute, so I would welcome any suggestions and criticism. I have based everything off of the code for the gid15 dataset. Running pytest it passed all the tests and had 100% cover on loveda.py.
The dataset differentiates between "rural" and "urban" images so here are some samples respectively from the training split.
