extract_archive: support deflate64-compressed zip files #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjstewart
commented
Dec 14, 2021
| @@ -81,6 +80,26 @@ def __exit__(self, exc_type: None, exc_value: None, traceback: None) -> None: | |||
| pass | |||
|
|
|||
|
|
|||
| class _zipfile: | |||
There was a problem hiding this comment.
If we didn't need test coverage, this entire class could be replaced by:
try:
import zipfile_deflate64 as zipfile
except ImportError:
import zipfileIf zipfile_deflate64 is not installed and a user opens a deflate64-compressed zip file, they'll see the error message:
Traceback (most recent call last):
File "<stdin>", line 3, in <module>
File "/Users/Adam/.spack/.spack-env/._view/tmizjnr2yebouizawyxzmo3gwignw5lz/lib/python3.8/zipfile.py", line 1647, in extractall
self._extract_member(zipinfo, path, pwd)
File "/Users/Adam/.spack/.spack-env/._view/tmizjnr2yebouizawyxzmo3gwignw5lz/lib/python3.8/zipfile.py", line 1700, in _extract_member
with self.open(member, pwd=pwd) as source, \
File "/Users/Adam/.spack/.spack-env/._view/tmizjnr2yebouizawyxzmo3gwignw5lz/lib/python3.8/zipfile.py", line 1571, in open
return ZipExtFile(zef_file, mode, zinfo, pwd, True)
File "/Users/Adam/.spack/.spack-env/._view/tmizjnr2yebouizawyxzmo3gwignw5lz/lib/python3.8/zipfile.py", line 819, in __init__
self._decompressor = _get_decompressor(self._compress_type)
File "/Users/Adam/.spack/.spack-env/._view/tmizjnr2yebouizawyxzmo3gwignw5lz/lib/python3.8/zipfile.py", line 720, in _get_decompressor
_check_compression(compress_type)
File "/Users/Adam/.spack/.spack-env/._view/tmizjnr2yebouizawyxzmo3gwignw5lz/lib/python3.8/zipfile.py", line 700, in _check_compression
raise NotImplementedError("That compression method is not supported")
NotImplementedError: That compression method is not supported
We could potentially catch this error and add a more helpful error message like we do with rarfile, but it isn't clear how to test this (see PR description).
|
This library might actually be broken: brianhelba/zipfile-deflate64#19 |
adamjstewart
force-pushed
the
fixes/zipfile-deflate64
branch
from
a3a1c65
to
9a2a4ff
Compare
adamjstewart
force-pushed
the
fixes/zipfile-deflate64
branch
from
3e0b5f5
to
29ba6fb
Compare
|
Can't tell if RtD is broken or this PR is broken, but I'm going to guess the former. |
adamjstewart
force-pushed
the
fixes/zipfile-deflate64
branch
from
29ba6fb
to
306c931
Compare
adamjstewart
force-pushed
the
fixes/zipfile-deflate64
branch
from
306c931
to
cab6976
Compare
adamjstewart
force-pushed
the
fixes/zipfile-deflate64
branch
from
cab6976
to
1007c6e
Compare
isaaccorley
approved these changes
Jan 15, 2022
adamjstewart
added a commit
that referenced
this pull request
Mar 19, 2022
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59