plotting method Cyclone dataset #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we also want to add the ground truth label to the plot title, right? I believe we do that for other classification/regression datasets where plotting has been added. |
|
In eurosat.py for example, there is a boolean show_titles, which controls whether or not to show the label/prediction. Should I do it like that? |
|
Yep, I think that's what we want to do here. |
|
In #288, it was mentioned that in case of predictions, the sample contains "predictions" as a key, however, in eurosat.py, the key in the sample is "prediction" without s. which of the two should it be? |
|
I think "prediction" is correct, none of our other keys (image, mask, label) are plural. |
calebrob6
approved these changes
Dec 18, 2021
19 tasks
adamjstewart
added
utilities
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* plotting method Cyclone dataset * adding label and prediction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding plotting method for Cyclone dataset.
