-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plotting method for COWC dataset #300
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be able to put most of the plotting code in the COWC
base class, then the subclasses only need to decide what the label/prediction is. If it makes it easier, we could even consider going back from True/False to 1/0 and then we don't need separate plotting code.
This looks good to me, but I'll let others review. I'm starting to flip flop, and I think it might be simpler (less code to maintain) if we go back to your first commit where there's a single plot function for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this lgtm, although I'm curious why the example plots look to be grayscale? Are the images not RGB?
The images should be RGB, this seems like a bug in the plotting code in this PR. |
I believe that while all images in the dataset have RGB channels, they are not all colored, see the example on the dataset website. |
Can you show one of the colored images from your plotting method? |
I think we should go back to having a single |
* plotting method cowc dataset * boolean label for detection * restructure plotting method * typo * label title not as variable * single plot method in super class Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
Adding plotting method for COWC dataset.
COWCCounting:
COWCDetection
An Example of image with color: