-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indices Tutorial Refactor #308
Indices Tutorial Refactor #308
Conversation
isaaccorley
commented
Dec 19, 2021
- Refactors all gdal usage with rasterio
- Removes tqdm usage
Can you also remove gdal installation in |
Done Edit: Actually do we need to remove the - name: Install apt dependencies
run: |
sudo apt-add-repository ppa:ubuntugis/ubuntugis-unstable
sudo apt-get update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub won't even let me view the diff so I'm assuming the notebook changes are good, CI will test it during the release anyway.
* refactor tqdm and gdal out * remove gdal/tqdm installation in actions * remove apt deps install
"It worked on my machine" |
We may have to start thinking about alternatives to raw notebook files if we can't even review them on GitHub. PyTorch does a weird thing where the code is stored in a Python file but translated to a notebook when you launch it on Colab? |
I normally go to the branch and view it there. Doesn't work through the mobile app though so still need to use a browser. Although sometimes you get the issue of browsers not loading notebooks. |
Yeah, this happened to be a browser issue. Even from the command line, grep becomes useless because it gets swallowed up by one of those massive random hashes that includes all possible substrings somehow. I don't personally use notebooks, so it's really cumbersome to deal with all of these issues. Also, it's hard for tools like black/isort/mypy/flake8 to run on these notebooks, although not impossible. |
Few things:
- Cool!
- nbQA (https://github.com/nbQA-dev/nbQA) lets you run black, isort, etc.
on notebooks easily
- `nbconvert` can convert back and forth between ipynb and py
- vscode has the best visual notebook diff tool I've seen
- line diffs of notebooks are usually useless if someone has actually
re-run the cells because there is a piece of metadata that changes per
cells, and the binary blobs will be ridiculous
- I'm at best lukewarm about doing away with the actual notebook files (in
favor of py files that get rendered as notebooks) as I don't think
reviewing notebooks is _that_ burdensome
…On Sun, Dec 19, 2021 at 2:47 PM Adam J. Stewart ***@***.***> wrote:
Yeah, this happened to be a browser issue. Even from the command line,
grep becomes useless because it gets swallowed up by one of those massive
random hashes that includes all possible substrings somehow. I don't
personally use notebooks, so it's really cumbersome to deal with all of
these issues. Also, it's hard for tools like black/isort/mypy/flake8 to run
on these notebooks, although not impossible.
—
Reply to this email directly, view it on GitHub
<#308 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIJUTTDHV5FTESTXGJAHZTURZOIDANCNFSM5KMJ4UGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
* refactor tqdm and gdal out * remove gdal/tqdm installation in actions * remove apt deps install