Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indices Tutorial Refactor #308

Merged
merged 3 commits into from
Dec 19, 2021

Conversation

isaaccorley
Copy link
Collaborator

  • Refactors all gdal usage with rasterio
  • Removes tqdm usage

@isaaccorley isaaccorley self-assigned this Dec 19, 2021
@isaaccorley isaaccorley added this to the 0.1.1 milestone Dec 19, 2021
@adamjstewart
Copy link
Collaborator

Can you also remove gdal installation in .github/workflows/releases.yaml?

@isaaccorley
Copy link
Collaborator Author

isaaccorley commented Dec 19, 2021

Can you also remove gdal installation in .github/workflows/releases.yaml?

Done

Edit:

Actually do we need to remove the install apt dependencies?

    - name: Install apt dependencies
      run: |
        sudo apt-add-repository ppa:ubuntugis/ubuntugis-unstable
        sudo apt-get update

Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub won't even let me view the diff so I'm assuming the notebook changes are good, CI will test it during the release anyway.

@adamjstewart adamjstewart merged commit 44e1ab9 into microsoft:main Dec 19, 2021
adamjstewart pushed a commit that referenced this pull request Dec 19, 2021
* refactor tqdm and gdal out

* remove gdal/tqdm installation in actions

* remove apt deps install
@isaaccorley
Copy link
Collaborator Author

"It worked on my machine"

@adamjstewart
Copy link
Collaborator

We may have to start thinking about alternatives to raw notebook files if we can't even review them on GitHub. PyTorch does a weird thing where the code is stored in a Python file but translated to a notebook when you launch it on Colab?

@isaaccorley
Copy link
Collaborator Author

I normally go to the branch and view it there. Doesn't work through the mobile app though so still need to use a browser. Although sometimes you get the issue of browsers not loading notebooks.

@adamjstewart
Copy link
Collaborator

Yeah, this happened to be a browser issue. Even from the command line, grep becomes useless because it gets swallowed up by one of those massive random hashes that includes all possible substrings somehow. I don't personally use notebooks, so it's really cumbersome to deal with all of these issues. Also, it's hard for tools like black/isort/mypy/flake8 to run on these notebooks, although not impossible.

@calebrob6
Copy link
Member

calebrob6 commented Dec 19, 2021 via email

@isaaccorley isaaccorley deleted the tutorials/indices-refactor branch December 19, 2021 23:13
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* refactor tqdm and gdal out

* remove gdal/tqdm installation in actions

* remove apt deps install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants