Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SpaceNet plot fns #311

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Conversation

ashnair1
Copy link
Collaborator

@ashnair1 ashnair1 commented Dec 20, 2021

Add option to plot prediction if present in sample dict

Plot works for the following cases:

  • Plot only image
  • Plot image and mask(label)
  • Plot image, mask and prediction

Following cases won't work:

  • Plot only prediction
  • Plot only mask
  • Plot mask and prediction
  • Plot image and prediction

First two might not be that important. Not sure if we want to support the last two. If required this could be done in a follow up PR.

@adamjstewart adamjstewart added the datasets Geospatial or benchmark datasets label Dec 20, 2021
@adamjstewart adamjstewart added this to the 0.2.0 milestone Dec 20, 2021
@isaaccorley
Copy link
Collaborator

In other datasets we generally only support image/target or image/target/predictions if predictions is available. I wouldn't worry about supporting the others.

Copy link
Member

@calebrob6 calebrob6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@adamjstewart adamjstewart merged commit fe590b1 into microsoft:main Dec 21, 2021
@adamjstewart adamjstewart mentioned this pull request Dec 21, 2021
19 tasks
@ashnair1 ashnair1 deleted the snplot-update branch December 21, 2021 05:07
@adamjstewart adamjstewart added utilities Utilities for working with geospatial data and removed utilities Utilities for working with geospatial data labels Jan 2, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants