Add pad_size arg to OSCDDataModule #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebrob6
previously approved these changes
Jan 1, 2022
adamjstewart
reviewed
Jan 1, 2022
adamjstewart
approved these changes
Jan 1, 2022
|
Merging this because mypy issues are unrelated. |
adamjstewart
added
utilities
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* add pad_size arg to OSCDDataModule, update configs * add EOL to configs * hacking config files * Update oscd_all.yaml * Update oscd_rgb.yaml Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
pad_sizeargument to theOSCDDataModule. Previously the pad size for thePadTotransform used in the val/test steps was hardcoded to(1280, 1280).(64, 64)pad size which is the smallest I could get a U-Net to take due to downsampling. This should reduce the memory consumption used when testing the trainers/datamodules.